feat: [M3-7841] - Add the capability to search for a Linode by ID using the main search tool. #11112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b274baf.
cpathipa
requested review from
AzureLatte,
mjac0bs and
hana-akamai
and removed request for
a team
…g the main search tool.
|
Coverage Report: ✅ |
jaalah-akamai
approved these changes
Oct 16, 2024
cpathipa
commented
Oct 16, 2024
| @@ -158,7 +158,7 @@ export const bucketToSearchableItem = ( | |||
| cluster: bucket.cluster, | |||
| created: bucket.created, | |||
| description: readableBytes(bucket.size).formatted, | |||
| icon: 'bucket', | |||
| icon: 'storage', | |||
There was a problem hiding this comment.
This results rending bucket icon for storage bucket search
mjac0bs
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
✅ Used main search tool to search any linode by typing its id, both by itself and prefixed by id:
✅ Verified bucket icon for storage bucket search result instead of the linode icon
✅ Tested existing search functionality and didn't see regressions
Looks good, thanks Chandra! Left some very minor nits for grammar.
packages/manager/cypress/e2e/core/linodes/search-linodes.spec.ts
Outdated
Show resolved
Hide resolved
mjac0bs
added
Approved
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com>
Cloud Manager E2E
|
||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Run status |
|
| Run duration | 29m 31s |
| Commit |
|
| Committer | cpathipa |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
9
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
438
|
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR add's capability to the main search tool to search linode by ID, example id: 1234 should show the matching result.
Also fixes the issue of rendering correct icon for the buckets in the results list.
Target release date 🗓️
10/28
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
As an Author I have considered 🤔
Check all that apply